Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2800)

Unified Diff: chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html

Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments from yoz and shess. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html
diff --git a/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html b/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html
index f946bf0e27b62c0a2f62c523062b65c6f474850a..a032c6889bda58cd4cdf71430e35db4bc0793c15 100644
--- a/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html
+++ b/chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html
@@ -2,13 +2,15 @@
<script type="text/javascript">
var ctrlDown = false;
document.onkeyup = function(e) {
- if (e.keyCode == 17)
+ // Ctrl is 17, left Command is 91, right Command is 93
+ if (e.keyCode == 17 || e.keyCode == 91 || e.keyCode == 93)
ctrlDown = false;
}
document.onkeydown = function(e) {
- if (e.keyCode == 17)
+ // Ctrl is 17, left Command is 91, right Command is 93
+ if (e.keyCode == 17 || e.keyCode == 91 || e.keyCode == 93) {
ctrlDown = true;
- else if (String.fromCharCode(e.keyCode) == 'D' && ctrlDown) {
+ } else if (String.fromCharCode(e.keyCode) == 'D' && ctrlDown) {
document.body.bgColor = "magenta";
return false;
}
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698