chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h - Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from yoz and shess. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/chrome_event_processing_window.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

index f3fdcc9c8d6363712d07c06e38e25bc620039e36..248504229e88d0212b279ae688eb8b2bf64f750d 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.h

@@ -10,6 +10,7 @@

#include "chrome/browser/extensions/extension_keybinding_registry.h"

#include "ui/base/accelerators/accelerator.h"

+#include "ui/base/accelerators/accelerator_manager.h"

#include "ui/gfx/native_widget_types.h"

class Profile;

@@ -48,7 +49,8 @@ class ExtensionKeybindingRegistryCocoa

// For a given keyboard |event|, see if a known Extension Command registration

// exists and route the event to it. Returns true if the event was handled,

// false otherwise.

- bool ProcessKeyEvent(const content::NativeWebKeyboardEvent& event);

+ bool ProcessKeyEvent(const content::NativeWebKeyboardEvent& event,

+ ui::AcceleratorManager::HandlerPriority priority);

protected:

// Overridden from ExtensionKeybindingRegistry: