chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments from yoz and shess. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index f51bf9f2de62bda7bf2b8376e26d8d78c073cd7b..43836afd0fd03327faf2f179239bcd80b0de36f2 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -579,7 +579,9 @@ bool BrowserWindowCocoa::PreHandleKeyboardEvent(

return false;

if (event.type == blink::WebInputEvent::RawKeyDown &&

- [controller_ handledByExtensionCommand:event.os_event])

+ [controller_

+ handledByExtensionCommand:event.os_event

+ priority:ui::AcceleratorManager::kHighPriority])

return true;

int id = [BrowserWindowUtils getCommandId:event];

« no previous file with comments | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | no next file with comments »