chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html - Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html

Issue 388313002: mac: Allow WebContents key handling to supplant extension overrides of the bookmark shortcut. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment from wittman. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <head>	1 <head>

2 <script type="text/javascript">	2 <script type="text/javascript">

3 var ctrlDown = false;	3 var ctrlDown = false;

4 document.onkeyup = function(e) {	4 document.onkeyup = function(e) {

5 if (e.keyCode == 17)	5 if (e.keyCode == 17 \|\| e.keyCode == 91 \|\| e.keyCode == 93)
	Yoyo Zhou 2014/07/15 19:46:37 It would be nice to comment on what these values m It would be nice to comment on what these values mean. erikchen 2014/07/15 20:48:40 Done. Show quoted text On 2014/07/15 19:46:37, Yoyo Zhou wrote: > It would be nice to comment on what these values mean. Done.
6 ctrlDown = false;	6 ctrlDown = false;

7 }	7 }

8 document.onkeydown = function(e) {	8 document.onkeydown = function(e) {

9 if (e.keyCode == 17)	9 if (e.keyCode == 17 \|\| e.keyCode == 91 \|\| e.keyCode == 93) {

10 ctrlDown = true;	10 ctrlDown = true;

11 else if (String.fromCharCode(e.keyCode) == 'D' && ctrlDown) {	11 } else if (String.fromCharCode(e.keyCode) == 'D' && ctrlDown) {

12 document.body.bgColor = "magenta";	12 document.body.bgColor = "magenta";

13 return false;	13 return false;

14 }	14 }

15 };	15 };

16 </script>	16 </script>

17 </head>	17 </head>

OLD	NEW

« chrome/browser/ui/cocoa/browser_window_controller.mm ('K') | « chrome/browser/ui/cocoa/extensions/extension_keybinding_registry_cocoa.mm ('k') | no next file » | no next file with comments »