Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1682)

Issue 388303002: DevTools: Get rid of WebInspector.TargetObserver (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Get rid of WebInspector.TargetObserver BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178073

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -55 lines) Patch
M LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileView.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/profiler/HeapSnapshotView.js View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 2 chunks +10 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
6 years, 5 months ago (2014-07-14 15:18:03 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-14 15:19:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/388303002/1
6 years, 5 months ago (2014-07-14 15:20:59 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 16:23:18 UTC) #4
Message was sent while issue was closed.
Change committed as 178073

Powered by Google App Engine
This is Rietveld 408576698