Issue 388273002: Add a command line tool for validating the tileStore.

Issue 388273002: Add a command line tool for validating the tileStore. (Closed)

Created:
6 years, 5 months ago by jcgregorio

Modified:
6 years, 5 months ago

Reviewers:
kelvinly, mtklein, benchen

CC:
reviews_skia.org, benchen, kelvinly

Base URL:
https://skia.googlesource.com/buildbot.git@master

Project:
skiabuildbot

Visibility:
Public.

More Reviews

Description

Add a command line tool for validating the tileStore. Appears to work as it found that the current tile store is invalid, seems that commits are spanning tiles. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/95d2e9cd9259527ce2ba147c86f9395aef7dfcf7

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -1 line)			Patch
	M	perf/server/Makefile	View		2 chunks	+3 lines, -1 line	0 comments	Download
	A	perf/server/src/tiletool/main.go	View	1 2 3 4	1 chunk	+123 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

kelvinly

lgtm, although I suggested adding a little more stuff https://codereview.chromium.org/388273002/diff/40001/perf/server/src/tiletool/main.go File perf/server/src/tiletool/main.go (right): https://codereview.chromium.org/388273002/diff/40001/perf/server/src/tiletool/main.go#newcode34 perf/server/src/tiletool/main.go:34: ...

6 years, 5 months ago (2014-07-14 15:23:31 UTC) #2

jcgregorio

https://codereview.chromium.org/388273002/diff/40001/perf/server/src/tiletool/main.go File perf/server/src/tiletool/main.go (right): https://codereview.chromium.org/388273002/diff/40001/perf/server/src/tiletool/main.go#newcode34 perf/server/src/tiletool/main.go:34: } On 2014/07/14 15:23:30, kelvinly wrote: > Would it ...

6 years, 5 months ago (2014-07-14 15:30:30 UTC) #3

mtklein

lgtm https://codereview.chromium.org/388273002/diff/60001/perf/server/src/tiletool/main.go File perf/server/src/tiletool/main.go (right): https://codereview.chromium.org/388273002/diff/60001/perf/server/src/tiletool/main.go#newcode40 perf/server/src/tiletool/main.go:40: fmt.Printf("ERROR: Tiles out of order: Commit (%s) %d ...

6 years, 5 months ago (2014-07-14 16:18:34 UTC) #5

jcgregorio

https://codereview.chromium.org/388273002/diff/60001/perf/server/src/tiletool/main.go File perf/server/src/tiletool/main.go (right): https://codereview.chromium.org/388273002/diff/60001/perf/server/src/tiletool/main.go#newcode40 perf/server/src/tiletool/main.go:40: fmt.Printf("ERROR: Tiles out of order: Commit (%s) %d timestamp ...

6 years, 5 months ago (2014-07-14 16:21:39 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/388273002/80001

6 years, 5 months ago (2014-07-14 16:21:50 UTC) #8

commit-bot: I haz the power

6 years, 5 months ago (2014-07-14 16:21:55 UTC) #9

Message was sent while issue was closed.

Change committed as 95d2e9cd9259527ce2ba147c86f9395aef7dfcf7

Expand Messages | Collapse Messages