Macro out unused functions in memory_mac.mm

Macro out unused functions in memory_mac.mm

These functions are defined but not used on ASan-enabled build.
That causes build failure on ASan-enabled build without -w flag.

BUG=162783
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283766

[tzik, 2014-07-14 14:35:07]

PTL

[Nico, 2014-07-16 19:34:25]

lgtm as far as I can tell.

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac.mm
File base/process/memory_mac.mm (right):

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac....
base/process/memory_mac.mm:174: #if !defined(HANDLE_MEMORY_CORRUPTION_MANUALLY)
Since the comment that used to be here is now at the top, I'd just write

#if defined(HANDLE_MEMORY_CORRUPTION_MANUALLY)
...code...
#endif

The "return" statement isn't really needed here.

[Scott Hess - ex-Googler, 2014-07-16 19:53:47]

lgtm, also, with a minor nit.  You can checkin without addressing the nit if you
disagree with me, it was just a preference.

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac.mm
File base/process/memory_mac.mm (right):

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac....
base/process/memory_mac.mm:523: #if !defined(ADDRESS_SANITIZER)
I'd invert this and put the ASAN case closer to the test, with the non-ASAN case
in the #else.

[tzik, 2014-07-17 08:17:27]

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac.mm
File base/process/memory_mac.mm (right):

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac....
base/process/memory_mac.mm:174: #if !defined(HANDLE_MEMORY_CORRUPTION_MANUALLY)
On 2014/07/16 19:34:24, Nico (away) wrote:
> Since the comment that used to be here is now at the top, I'd just write
> 
> #if defined(HANDLE_MEMORY_CORRUPTION_MANUALLY)
> ...code...
> #endif
> 
> The "return" statement isn't really needed here.

Done.

https://codereview.chromium.org/388263002/diff/80001/base/process/memory_mac....
base/process/memory_mac.mm:523: #if !defined(ADDRESS_SANITIZER)
On 2014/07/16 19:53:47, Scott Hess wrote:
> I'd invert this and put the ASAN case closer to the test, with the non-ASAN
case
> in the #else.

Done.

[tzik, 2014-07-17 08:17:39]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-07-17 08:18:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tzik@chromium.org/388263002/100001

[commit-bot: I haz the power, 2014-07-17 13:28:47]

Change committed as 283766