Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 388233002: Version 3.27.34.6 (merged r22029) (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Version 3.27.34.6 (merged r22029) Compile optimized code with active debugger but no break points. BUG=386492 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22375

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/debug-compile-optimized.js View 1 chunk +7 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-14 13:03:26 UTC) #1
Michael Achenbach
lgtm (rubber stamp)
6 years, 5 months ago (2014-07-14 13:06:35 UTC) #2
Yang
6 years, 5 months ago (2014-07-14 13:13:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22375 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698