Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 388183002: Removed some copy-n-paste from StackFrame::Foo API entries. (Closed)

Created:
6 years, 5 months ago by Sven Panne
Modified:
6 years, 5 months ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Removed some copy-n-paste from StackFrame::Foo API entries. BUG=v8:3436 LOG=y R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22390

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -71 lines) Patch
M src/api.cc View 1 chunk +39 lines, -71 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
Not sure if we should unify the kind of HandleScope for consistency, I've got no ...
6 years, 5 months ago (2014-07-14 08:44:59 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-14 18:45:55 UTC) #2
Sven Panne
6 years, 5 months ago (2014-07-15 06:59:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698