DevTools: Do not crash or hang on console.log()

DevTools: Do not crash or hang on console.log()

Now we try to build a string representation of a V8 value without causing side
effects. In 99% cases this will be the same result as before, but we won't crash
or hang any more in 99% reported cases.

The crash still possible if redefined, for example, function.toString().
Would have been ideal if V8 also exposed FunctionProtoToString, RegExpProtoToString and etc.

We use V8's ObjectProtoToString on almost all Objects and mimic V8's ArrayToString on small
arrays. For other types we call ToString.

BUG=391475
R=yurys

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178449

[yurys, 2014-07-14 16:36:09]

lgtm

https://codereview.chromium.org/388093002/diff/100001/LayoutTests/http/tests/...
File
LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt
(right):

https://codereview.chromium.org/388093002/diff/100001/LayoutTests/http/tests/...
LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:3:
CONSOLE MESSAGE: line 4: [object global]
It is unfortunate that it it now differs from result of ""+window. Can we fix
that?

https://codereview.chromium.org/388093002/diff/100001/Source/core/inspector/S...
File Source/core/inspector/ScriptArguments.cpp (right):

https://codereview.chromium.org/388093002/diff/100001/Source/core/inspector/S...
Source/core/inspector/ScriptArguments.cpp:52: if (!builder.append(value))
This check seems redundant.

[aandrey, 2014-07-18 08:54:48]

https://codereview.chromium.org/388093002/diff/100001/LayoutTests/http/tests/...
File
LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt
(right):

https://codereview.chromium.org/388093002/diff/100001/LayoutTests/http/tests/...
LayoutTests/http/tests/inspector-enabled/console-clear-arguments-on-frame-remove-expected.txt:3:
CONSOLE MESSAGE: line 4: [object global]
On 2014/07/14 16:36:09, yurys wrote:
> It is unfortunate that it it now differs from result of ""+window. Can we fix
> that?

Done. Added a special check.

https://codereview.chromium.org/388093002/diff/100001/Source/core/inspector/S...
File Source/core/inspector/ScriptArguments.cpp (right):

https://codereview.chromium.org/388093002/diff/100001/Source/core/inspector/S...
Source/core/inspector/ScriptArguments.cpp:52: if (!builder.append(value))
On 2014/07/14 16:36:09, yurys wrote:
> This check seems redundant.

Nope, builder can also fail w/o throwing an exception, i.e. it could contain an
incomplete result in the buffer after a failed append().

[aandrey, 2014-07-18 08:55:35]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-18 08:56:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/388093002/120001

[commit-bot: I haz the power, 2014-07-18 10:05:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16087)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17677)

[commit-bot: I haz the power, 2014-07-18 10:44:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 10:44:09]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[aandrey, 2014-07-18 11:20:36]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-18 11:21:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/388093002/120001

[commit-bot: I haz the power, 2014-07-18 12:25:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[commit-bot: I haz the power, 2014-07-18 13:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-18 13:09:22]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[aandrey, 2014-07-18 13:31:40]

The CQ bit was checked by aandrey@chromium.org

[aandrey, 2014-07-18 13:31:51]

The CQ bit was unchecked by aandrey@chromium.org

[aandrey, 2014-07-18 13:34:23]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-18 13:35:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/388093002/140001

[commit-bot: I haz the power, 2014-07-18 14:47:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17727)

[commit-bot: I haz the power, 2014-07-18 15:26:55]

Change committed as 178449