sync/engine/download.h - Issue 38803003: sync: Implement per-type update processing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sync/engine/download.h

Issue 38803003: sync: Implement per-type update processing (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clean up and add comments Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | sync/engine/download.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef SYNC_ENGINE_DOWNLOAD_H_	5 #ifndef SYNC_ENGINE_DOWNLOAD_H_

6 #define SYNC_ENGINE_DOWNLOAD_H_	6 #define SYNC_ENGINE_DOWNLOAD_H_

7	7

8 #include "sync/base/sync_export.h"	8 #include "sync/base/sync_export.h"

9 #include "sync/internal_api/public/base/model_type.h"	9 #include "sync/internal_api/public/base/model_type.h"

10 #include "sync/internal_api/public/util/syncer_error.h"	10 #include "sync/internal_api/public/util/syncer_error.h"

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48 // periodic polling.	48 // periodic polling.

49 SYNC_EXPORT_PRIVATE void BuildDownloadUpdatesForPoll(	49 SYNC_EXPORT_PRIVATE void BuildDownloadUpdatesForPoll(

50 sessions::SyncSession* session,	50 sessions::SyncSession* session,

51 bool create_mobile_bookmarks_folder,	51 bool create_mobile_bookmarks_folder,

52 ModelTypeSet request_types,	52 ModelTypeSet request_types,

53 sync_pb::ClientToServerMessage* client_to_server_message);	53 sync_pb::ClientToServerMessage* client_to_server_message);

54	54

55 // Sends the specified message to the server and stores the response in a member	55 // Sends the specified message to the server and stores the response in a member

56 // of the \|session\|'s StatusController.	56 // of the \|session\|'s StatusController.

57 SYNC_EXPORT_PRIVATE SyncerError	57 SYNC_EXPORT_PRIVATE SyncerError

58 ExecuteDownloadUpdates(sessions::SyncSession* session,	58 ExecuteDownloadUpdates(ModelTypeSet request_types,
	rlarocque 2013/10/24 20:47:27 Some of the issues I ran into in this change made Some of the issues I ran into in this change made me question whether or not we should allow ProxyTypes to be sent down to this layer. Maybe we should filter them out at the SyncScheduler, or even earlier. Thoughts?
	59 sessions::SyncSession* session,

59 sync_pb::ClientToServerMessage* msg);	60 sync_pb::ClientToServerMessage* msg);

60	61

61 } // namespace syncer	62 } // namespace syncer

62	63

63 #endif // SYNC_ENGINE_DOWNLOAD_H_	64 #endif // SYNC_ENGINE_DOWNLOAD_H_

OLD	NEW