Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4724)

Unified Diff: chrome/browser/views/bookmark_menu_controller_views.cc

Issue 388007: Fixes possible crash in showing bookmark menu. The problem occurred... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/bookmark_menu_controller_views.cc
===================================================================
--- chrome/browser/views/bookmark_menu_controller_views.cc (revision 31560)
+++ chrome/browser/views/bookmark_menu_controller_views.cc (working copy)
@@ -256,8 +256,7 @@
if (!alt_menu)
alt_menu = CreateMenu(node, start_index);
- if (alt_menu)
- menu_ = alt_menu;
+ menu_ = alt_menu;
*button = bookmark_bar_->GetMenuButtonForNode(node);
bookmark_bar_->GetAnchorPositionAndStartIndexForButton(
@@ -272,8 +271,20 @@
void BookmarkMenuController::BookmarkNodeFavIconLoaded(
BookmarkModel* model, const BookmarkNode* node) {
- if (node_to_menu_id_map_.find(node) != node_to_menu_id_map_.end())
- menu_->SetIcon(model->GetFavIcon(node), node_to_menu_id_map_[node]);
+ std::map<const BookmarkNode*, int>::iterator menu_pair =
+ node_to_menu_id_map_.find(node);
+ if (menu_pair == node_to_menu_id_map_.end())
+ return; // We're not showing a menu item for the node.
+
+ // Iterate through the menus looking for the menu containing node.
+ for (NodeToMenuMap::iterator i = node_to_menu_map_.begin();
+ i != node_to_menu_map_.end(); ++i) {
+ MenuItemView* menu_item = i->second->GetMenuItemByID(menu_pair->second);
+ if (menu_item) {
+ menu_item->SetIcon(model->GetFavIcon(node));
+ return;
+ }
+ }
}
MenuItemView* BookmarkMenuController::CreateMenu(const BookmarkNode* parent,
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698