Fixes possible crash in showing bookmark menu. The problem occurred...

Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31603

[sky, 2009-11-10 17:50:03]

Reviewers: jcampan,

Description:
Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.


Please review this at http://codereview.chromium.org/388007

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/views/bookmark_menu_controller_views.cc
   M     views/controls/menu/menu_item_view.h
   M     views/controls/menu/menu_item_view.cc

[sky, 2009-11-10 17:56:05]

Reviewers: jcampan,

Description:
Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.


Please review this at http://codereview.chromium.org/388007

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/views/bookmark_menu_controller_views.cc
   M     views/controls/menu/menu_item_view.h
   M     views/controls/menu/menu_item_view.cc

[sky, 2009-11-10 18:06:07]

Reviewers: jcampan,

Description:
Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.


Please review this at http://codereview.chromium.org/388007

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/views/bookmark_menu_controller_views.cc
   M     views/controls/menu/menu_item_view.h
   M     views/controls/menu/menu_item_view.cc

[sky, 2009-11-10 18:16:11]

Reviewers: jcampan,

Description:
Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.


Please review this at http://codereview.chromium.org/388007

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/views/bookmark_menu_controller_views.cc
   M     views/controls/menu/menu_item_view.h
   M     views/controls/menu/menu_item_view.cc

[jcampan, 2009-11-10 18:17:55]

LGTM

[jcampan, 2009-11-10 18:18:13]

LGTM

http://codereview.chromium.org/388007

[jcampan, 2009-11-10 18:24:16]

LGTM

http://codereview.chromium.org/388007

[sky, 2009-11-10 18:26:13]

Reviewers: jcampan,

Description:
Fixes possible crash in showing bookmark menu. The problem occurred
when you clicked on one top level menu on the bookmark bar, moused
over another menu and then we loaded favicons for the first menu. The
code needs to figure out which menu has the icon instead of invoking
set icon on menu_.

BUG=27067
TEST=make sure bookmark menus work ok.


Please review this at http://codereview.chromium.org/388007

SVN Base: svn://chrome-svn/chrome/trunk/src/

Affected files:
   M     chrome/browser/views/bookmark_menu_controller_views.cc
   M     views/controls/menu/menu_item_view.h
   M     views/controls/menu/menu_item_view.cc

[jcampan, 2009-11-10 18:34:33]

LGTM

http://codereview.chromium.org/388007