chrome/browser/sync/profile_sync_components_factory_impl.cc - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing unit test, added extra test case, addressed CR feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/profile_sync_components_factory_impl.cc

diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc

index 1b927ae07a776ce24932765e20d8cb65ad33190d..8cc64a30c183a361ce6d22ce833b64db7010f5f1 100644

--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc

+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc

@@ -185,7 +185,9 @@ void ProfileSyncComponentsFactoryImpl::DisableBrokenType(

const tracked_objects::Location& from_here,

const std::string& message) {

ProfileSyncService* p = ProfileSyncServiceFactory::GetForProfile(profile_);

- p->DisableDatatype(type, from_here, message);

+ syncer::SyncError error(

+ from_here, syncer::SyncError::DATATYPE_ERROR, message, type);

+ p->DisableDatatype(error);

}

DataTypeController::DisableTypeCallback

« no previous file with comments | « chrome/browser/sync/glue/typed_url_model_associator_unittest.cc ('k') | chrome/browser/sync/profile_sync_service.h » ('j') | no next file with comments »