chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed failing unit test, added extra test case, addressed CR feedback. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/non_frontend_data_type_controller.cc ('k') | chrome/browser/sync/glue/typed_url_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

diff --git a/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc b/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

index 7a44748e9b3f9045a836b026729875de9afb8f78..6799f9cbbd9895c89c3c9d41c336177cb3623833 100644

--- a/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

+++ b/chrome/browser/sync/glue/non_frontend_data_type_controller_unittest.cc

@@ -379,7 +379,7 @@ TEST_F(SyncNonFrontendDataTypeControllerTest,

SetAssociateExpectations();

SetActivateExpectations(DataTypeController::OK);

EXPECT_CALL(*dtc_mock_.get(), RecordUnrecoverableError(_, "Test"));

- EXPECT_CALL(service_, DisableDatatype(_, _, _))

+ EXPECT_CALL(service_, DisableDatatype(_))

.WillOnce(InvokeWithoutArgs(non_frontend_dtc_.get(),

&NonFrontendDataTypeController::Stop));

SetStopExpectations();