chrome/browser/sync/profile_sync_service.h - Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 388003002: Sync: Display non-severe errors on about:sync in gray color rather than red. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/typed_url_data_type_controller.cc ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | components/sync_driver/failed_data_types_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service.h

diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h

index 5b695fbf5e1c82ba958b9ce9a0da1a7034ce2b01..3341234ec3992acc6449d2b561eb58bd66cb185a 100644

--- a/chrome/browser/sync/profile_sync_service.h

+++ b/chrome/browser/sync/profile_sync_service.h

@@ -552,6 +552,13 @@ class ProfileSyncService : public ProfileSyncServiceBase,

// Called when a datatype wishes to disable itself. Note, this does not change

// preferred state of a datatype and is not persisted across restarts.

virtual void DisableDatatype(syncer::ModelType type,

Nicolas Zea 2014/07/14 17:36:02 Does it make more sense to just pass a syncer::Syn

stanisc 2014/07/15 16:10:00 OK. I've done that.

+ syncer::SyncError::ErrorType error_type,

+ const tracked_objects::Location& from_here,

+ std::string message);

+ // Overloaded version of DisableDatatype that defaults to DATATYPE_ERROR

+ // error type.

+ void DisableDatatype(syncer::ModelType type,

const tracked_objects::Location& from_here,

Nicolas Zea 2014/07/14 17:36:02 nit: fix indent

stanisc 2014/07/15 16:10:00 Done.

std::string message);