MacViews: Change Widget context type to NativeWindow

Change the type of InitParams.context from gfx::NativeView to
gfx::NativeWindow.

With aura, gfx::NativeView and gfx::NativeWindow both map to aura::Window.
But on Mac they map to different types (NSWindow and NSView), so they can't
be used interchangeably.

|context| is used to determine the desktop type, and most of the call sites
are looking to pass a window instead of a view.
By changing context's type to gfx::NativeWindow, we get these call sites to
compile with MacViews while maintaining previous behavior with aura.

BUG=390755
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283126

[Andre, 2014-07-11 23:28:44]

Trent, WDYT?

[tapted, 2014-07-14 00:33:14]

lgtm - I can't really see any downsides to this.. I would just spruce up the CL
description a little. That is, callsites are passing a NativeWindow because it
feels more "correct", and I think that's the case:

I went back through the archaeology - https://codereview.chromium.org/11364053/
suggests |context| came about to help determine the desktop type. I can't think
of a case where a view would work where a window wouldn't, and it's certainly
true that most calls sites are looking to pass something like `GetRootWindow`,
i.e. a window.

(that is, the description doesn't make clear that it's the API that's "wrong",
rather than the callsites)

And I don't think there's a downside wrt correctness. i.e. one might say "this
helps because it ensures Mac is not using it - it should always be NULL", but it
should still be strongly typed.

And, don't forget to leave an empty line after the first line of the CL
description :)

https://codereview.chromium.org/387993004/diff/40001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc
(right):

https://codereview.chromium.org/387993004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc:101:
: public testing::Test {
not for this CL, but this should be inheriting from ViewsTestBase, so it has
access to GetContext() and can do away with all the #ifdefs :/

[tapted, 2014-07-14 00:36:20]

oh, and there should be a `BUG=` -- 390755 is probably appropriate

[Andre, 2014-07-14 17:49:10]

Scott, PTAL.

https://codereview.chromium.org/387993004/diff/40001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc
(right):

https://codereview.chromium.org/387993004/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc:101:
: public testing::Test {
On 2014/07/14 00:33:14, tapted wrote:
> not for this CL, but this should be inheriting from ViewsTestBase, so it has
> access to GetContext() and can do away with all the #ifdefs :/

Acknowledged.

[sky, 2014-07-14 21:05:21]

LGTM

[Andre, 2014-07-14 21:05:58]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-07-14 21:07:59]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/andresantoso@chromium.org/387993004/40001

[commit-bot: I haz the power, 2014-07-15 01:33:06]

Change committed as 283126