sync/internal_api/sync_manager_impl.cc - Issue 387983004: sync: Support non-blocking initial sync in proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_manager_impl.cc

Issue 387983004: sync: Support non-blocking initial sync in proto (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase + fix comment Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/sync_manager_impl.cc

diff --git a/sync/internal_api/sync_manager_impl.cc b/sync/internal_api/sync_manager_impl.cc

index 256a5c9fdd4fc729720227c65405da8038895155..0f2f961031de91fccfa80a5f23d9613c3b7b4b9b 100644

--- a/sync/internal_api/sync_manager_impl.cc

+++ b/sync/internal_api/sync_manager_impl.cc

@@ -897,9 +897,8 @@ void SyncManagerImpl::RequestNudgeForDataTypes(

}

void SyncManagerImpl::NudgeForInitialDownload(syncer::ModelType type) {

- // TODO(rlarocque): Initial downloads should have a separate nudge type.

DCHECK(thread_checker_.CalledOnValidThread());

- RefreshTypes(ModelTypeSet(type));

+ scheduler_->ScheduleInitialSyncNudge(type);

}

void SyncManagerImpl::NudgeForCommit(syncer::ModelType type) {