Buffer four scanlines prior to blitting. We will eventually use this

src/core/SkScan_AntiPath.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkScanPriv.h"
@@ skipping 90 matching lines @@
 }
 
 /// Run-length-encoded supersampling antialiased blitter.
 class SuperBlitter : public BaseSuperBlitter {
 public:
     SuperBlitter(SkBlitter* realBlitter, const SkIRect& ir,
                  const SkRegion& clip);
 
     virtual ~SuperBlitter() {
         this->flush();
-        sk_free(fRuns.fRuns);
+        sk_free(fRunsBuffer);
     }
 
     /// Once fRuns contains a complete supersampled row, flush() blits
     /// it out through the wrapped blitter.
     void flush();
 
     /// Blits a row of pixels, with location and width specified
     /// in supersampled coordinates.
     virtual void blitH(int x, int y, int width) SK_OVERRIDE;
     /// Blits a rectangle of pixels, with location and size specified
     /// in supersampled coordinates.
     virtual void blitRect(int x, int y, int width, int height) SK_OVERRIDE;
 
 private:

[robertphillips, 2014/07/16 12:33:11]

Move this comment down into getRunsSz ?

[krajcevski, 2014/07/16 16:36:03]

Done.

+    // extra one to store the zero at the end

[robertphillips, 2014/07/16 12:33:11]

// The next 3 variables implement a circular buffer of the last 'n' runs. It is
used by the compression code to buffer up a block of runs to compress together ?

[krajcevski, 2014/07/16 16:36:03]

Done.

+    int         fRunsToBuffer;

[robertphillips, 2014/07/16 12:50:33]

void* ?

[krajcevski, 2014/07/16 16:36:03]

Done.

+    void *      fRunsBuffer;
+    int         fCurrentRun;
     SkAlphaRuns fRuns;
+
+    int getRunsSz() const { return (fWidth + 1 + (fWidth + 2)/2) * sizeof(int16_t); }
+

[robertphillips, 2014/07/16 12:33:11]

// This updates 'fRuns' to point to the current buffered run in 'fRunsBuffer' ?

[krajcevski, 2014/07/16 16:36:03]

Done.

+    void advanceRuns() {
+        const size_t kRunsSz = this->getRunsSz();
+        fCurrentRun = (fCurrentRun + 1) % fRunsToBuffer;
+        fRuns.fRuns = reinterpret_cast<int16_t*>(
+            reinterpret_cast<uint8_t*>(fRunsBuffer) + fCurrentRun * kRunsSz);
+        fRuns.fAlpha = reinterpret_cast<SkAlpha*>(fRuns.fRuns + fWidth + 1);
+        fRuns.reset(fWidth);
+    }
+
     int         fOffsetX;
 };
 
 SuperBlitter::SuperBlitter(SkBlitter* realBlitter, const SkIRect& ir,
                            const SkRegion& clip)
         : BaseSuperBlitter(realBlitter, ir, clip) {
-    const int width = fWidth;
+    fRunsToBuffer = realBlitter->requestRowsPreserved();
+    fRunsBuffer = sk_malloc_throw(fRunsToBuffer * this->getRunsSz());
+    fCurrentRun = -1;
 
-    // extra one to store the zero at the end
-    fRuns.fRuns = (int16_t*)sk_malloc_throw((width + 1 + (width + 2)/2) * sizeof(int16_t));
-    fRuns.fAlpha = (uint8_t*)(fRuns.fRuns + width + 1);
-    fRuns.reset(width);
+    this->advanceRuns();
 
     fOffsetX = 0;
 }
 
 void SuperBlitter::flush() {
     if (fCurrIY >= fTop) {
+
+        SkASSERT(fCurrentRun < fRunsToBuffer);
         if (!fRuns.empty()) {

[robertphillips, 2014/07/16 12:33:11]

Usually we put the ';' inside the ')' of the SkDEBUGCODE

[krajcevski, 2014/07/16 16:36:03]

Done.

-        //  SkDEBUGCODE(fRuns.dump();)
+            // SkDEBUGCODE(fRuns.dump());
             fRealBlitter->blitAntiH(fLeft, fCurrIY, fRuns.fAlpha, fRuns.fRuns);
-            fRuns.reset(fWidth);
+            this->advanceRuns();
             fOffsetX = 0;
         }
+
         fCurrIY = fTop - 1;
         SkDEBUGCODE(fCurrX = -1;)
     }
 }
 
 /** coverage_to_partial_alpha() is being used by SkAlphaRuns, which
     *accumulates* SCALE pixels worth of "alpha" in [0,(256/SCALE)]
     to produce a final value in [0, 255] and handles clamping 256->255
     itself, with the same (alpha - (alpha >> 8)) correction as
     coverage_to_exact_alpha().
@@ skipping 571 matching lines @@
         AntiFillPath(path, clip.bwRgn(), blitter);
     } else {
         SkRegion        tmp;
         SkAAClipBlitter aaBlitter;
 
         tmp.setRect(clip.getBounds());
         aaBlitter.init(blitter, &clip.aaRgn());
         SkScan::AntiFillPath(path, tmp, &aaBlitter, true);
     }
 }