Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 387953004: ozone: caca: Convert to PlatformWindow (Closed)

Created:
6 years, 5 months ago by spang
Modified:
6 years, 5 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

ozone: caca: Convert to PlatformWindow BUG=392280 TEST=built with chromeos==1 use_ozone==1 & ran caca on X11 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283858

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase & nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+511 lines, -423 lines) Patch
M ui/ozone/platform/caca/caca.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
D ui/ozone/platform/caca/caca_connection.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/ozone/platform/caca/caca_connection.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M ui/ozone/platform/caca/caca_event_factory.h View 1 1 chunk +11 lines, -15 lines 0 comments Download
M ui/ozone/platform/caca/caca_event_factory.cc View 1 4 chunks +81 lines, -78 lines 0 comments Download
D ui/ozone/platform/caca/caca_surface_factory.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/ozone/platform/caca/caca_surface_factory.cc View 1 chunk +0 lines, -147 lines 0 comments Download
A ui/ozone/platform/caca/caca_window.h View 1 1 chunk +95 lines, -0 lines 0 comments Download
A ui/ozone/platform/caca/caca_window.cc View 1 1 chunk +138 lines, -0 lines 0 comments Download
A + ui/ozone/platform/caca/caca_window_manager.h View 2 chunks +18 lines, -15 lines 0 comments Download
A ui/ozone/platform/caca/caca_window_manager.cc View 1 1 chunk +153 lines, -0 lines 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 4 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
spang
6 years, 5 months ago (2014-07-17 15:09:31 UTC) #1
dnicoara
lgtm https://codereview.chromium.org/387953004/diff/1/ui/ozone/platform/caca/caca_window.cc File ui/ozone/platform/caca/caca_window.cc (right): https://codereview.chromium.org/387953004/diff/1/ui/ozone/platform/caca/caca_window.cc#newcode81 ui/ozone/platform/caca/caca_window.cc:81: // for a message every |delay_| time delta. ...
6 years, 5 months ago (2014-07-17 17:27:54 UTC) #2
spang
https://codereview.chromium.org/387953004/diff/1/ui/ozone/platform/caca/caca_window.cc File ui/ozone/platform/caca/caca_window.cc (right): https://codereview.chromium.org/387953004/diff/1/ui/ozone/platform/caca/caca_window.cc#newcode81 ui/ozone/platform/caca/caca_window.cc:81: // for a message every |delay_| time delta. On ...
6 years, 5 months ago (2014-07-17 19:50:42 UTC) #3
spang
The CQ bit was checked by spang@chromium.org
6 years, 5 months ago (2014-07-17 19:51:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/387953004/20001
6 years, 5 months ago (2014-07-17 19:54:54 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:34:40 UTC) #6
Message was sent while issue was closed. 
Change committed as 283858

Powered by Google App Engine
This is Rietveld 408576698