chrome/browser/sync/glue/history_model_worker.cc - Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/history_model_worker.cc

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/history_service.h ('K') | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/history_model_worker.cc

diff --git a/chrome/browser/sync/glue/history_model_worker.cc b/chrome/browser/sync/glue/history_model_worker.cc

index 39b86263bb3e150ef7d01df8760fa0d51a76c5e5..6b53a077c90ddfaff00d9cfc3dcd04f4b67bc9c9 100644

--- a/chrome/browser/sync/glue/history_model_worker.cc

+++ b/chrome/browser/sync/glue/history_model_worker.cc

@@ -71,8 +71,8 @@ void PostWorkerTask(const base::WeakPtr<HistoryService>& history_service,

syncer::SyncerError* error) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

if (history_service.get()) {

- scoped_refptr<WorkerTask> task(new WorkerTask(work, done, error));

- history_service->ScheduleDBTask(task.get(), cancelable_tracker);

+ WorkerTask* task = new WorkerTask(work, done, error);

+ history_service->ScheduleDBTask(task, cancelable_tracker);

} else {

*error = syncer::CANNOT_DO_WORK;

done->Signal();