Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3908)

Unified Diff: chrome/browser/prerender/prerender_local_predictor.cc

Issue 387923002: Make HistoryDBTask not refcounted, and ensure it's destroyed on its origin thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: revert unnecessary changes Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/url_index_private_data.cc ('k') | chrome/browser/sync/glue/history_model_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_local_predictor.cc
diff --git a/chrome/browser/prerender/prerender_local_predictor.cc b/chrome/browser/prerender/prerender_local_predictor.cc
index 2e451e94c0fb0563987931cb9981a9def3b2db0b..0b686095936e49d53fd1195ee7920f574668e114 100644
--- a/chrome/browser/prerender/prerender_local_predictor.cc
+++ b/chrome/browser/prerender/prerender_local_predictor.cc
@@ -555,10 +555,12 @@ void PrerenderLocalPredictor::OnAddVisit(const history::BriefVisitInfo& info) {
RecordEvent(EVENT_GOT_HISTORY_ISSUING_LOOKUP);
CandidatePrerenderInfo* lookup_info_ptr = lookup_info.get();
history->ScheduleDBTask(
- new GetURLForURLIDTask(lookup_info_ptr,
- base::Bind(&PrerenderLocalPredictor::OnLookupURL,
- base::Unretained(this),
- base::Passed(&lookup_info))),
+ scoped_ptr<history::HistoryDBTask>(
+ new GetURLForURLIDTask(
+ lookup_info_ptr,
+ base::Bind(&PrerenderLocalPredictor::OnLookupURL,
+ base::Unretained(this),
+ base::Passed(&lookup_info)))),
&history_db_tracker_);
}
}
@@ -998,8 +1000,10 @@ void PrerenderLocalPredictor::Init() {
HistoryService* history = GetHistoryIfExists();
if (history) {
CHECK(!is_visit_database_observer_);
- history->ScheduleDBTask(new GetVisitHistoryTask(this, kMaxVisitHistory),
- &history_db_tracker_);
+ history->ScheduleDBTask(
+ scoped_ptr<history::HistoryDBTask>(
+ new GetVisitHistoryTask(this, kMaxVisitHistory)),
+ &history_db_tracker_);
history->AddVisitDatabaseObserver(this);
is_visit_database_observer_ = true;
} else {
« no previous file with comments | « chrome/browser/history/url_index_private_data.cc ('k') | chrome/browser/sync/glue/history_model_worker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698