Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tools/perf/benchmarks/dromaeo.py

Issue 387893004: Update dromaeo to use results.AddValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/dromaeo.py
diff --git a/tools/perf/benchmarks/dromaeo.py b/tools/perf/benchmarks/dromaeo.py
index 0953cad06fff334ad765356cfe3ae03ba427f002..e23e58ac2cf3f048a7f178abac9d4fe91e1cca8d 100644
--- a/tools/perf/benchmarks/dromaeo.py
+++ b/tools/perf/benchmarks/dromaeo.py
@@ -9,6 +9,7 @@ from metrics import power
from telemetry import benchmark
from telemetry.page import page_measurement
from telemetry.page import page_set
+from telemetry.value import scalar
class _DromaeoMeasurement(page_measurement.PageMeasurement):
@@ -71,11 +72,11 @@ class _DromaeoMeasurement(page_measurement.PageMeasurement):
suffix = page.url[page.url.index('?') + 1 :]
def AddResult(name, value):
- data_type = 'unimportant'
+ important = False
if name == suffix:
- data_type = 'default'
-
- results.Add(Escape(name), 'runs/s', value, data_type=data_type)
+ important = True
+ results.AddValue(scalar.ScalarValue(
+ results.current_page, Escape(name), 'runs/s', value, important))
aggregated = {}
for data in score:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698