Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 387893002: Pin to a specific version of ANGLE. (Closed)

Created:
6 years, 5 months ago by jcgregorio
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Pin to a specific version of ANGLE. Pulling from HEAD is dangerous, as we now know. This change is a temporary fix to open the tree, we need a system for which version of ANGLE we are pinning to. BUG=skia: NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/24969a3146d8041e68aedb0041c1ec37c5c2e313

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jcgregorio
6 years, 5 months ago (2014-07-11 12:58:26 UTC) #1
robertphillips
lgtm
6 years, 5 months ago (2014-07-11 13:02:32 UTC) #2
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 5 months ago (2014-07-11 13:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/387893002/20001
6 years, 5 months ago (2014-07-11 13:28:42 UTC) #4
jcgregorio
The CQ bit was unchecked by jcgregorio@google.com
6 years, 5 months ago (2014-07-11 13:30:40 UTC) #5
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 5 months ago (2014-07-11 13:30:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/387893002/20001
6 years, 5 months ago (2014-07-11 13:30:52 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 13:30:59 UTC) #8
Message was sent while issue was closed.
Change committed as 24969a3146d8041e68aedb0041c1ec37c5c2e313

Powered by Google App Engine
This is Rietveld 408576698