Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 387873002: For font weights >= 600, create bold system fonts. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

For font weights >= 600, create bold system fonts. Adjust the weight threshold used for creating bold system fonts down to 600, so as align with the weight matching specified by http://www.w3.org/TR/CSS21/fonts.html#propdef-font-weight It also aligns better with others. R=eae@chromium.org BUG=335050 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177999

Patch Set 1 #

Patch Set 2 : Add trivial test + rebaselines for now-failing tests #

Patch Set 3 : Add win/virtual/antialiasedtext expected outputs #

Patch Set 4 : Reupload #

Total comments: 2

Patch Set 5 : Test improved + adjust TestExpectations #

Patch Set 6 : Reupload.. #

Patch Set 7 : Reupload flakiness. #

Patch Set 8 : Reupload re-attempt #

Patch Set 9 : Reupload woes #

Messages

Total messages: 8 (0 generated)
eae
We really should pass the font weight (along with the width) along instead of trying ...
6 years, 5 months ago (2014-07-11 11:01:18 UTC) #1
sof
On 2014/07/11 11:01:18, eae wrote: > We really should pass the font weight (along with ...
6 years, 5 months ago (2014-07-11 11:05:54 UTC) #2
sof
When there's time, please take a look. The test is trivial, but perhaps sufficient? Also, ...
6 years, 5 months ago (2014-07-12 07:12:25 UTC) #3
eae
Correct, please add a [ NeedsRebaseline ] line for the new test. LGTM w/nit https://codereview.chromium.org/387873002/diff/60001/LayoutTests/fast/text/font-weight-600.html ...
6 years, 5 months ago (2014-07-12 07:32:46 UTC) #4
sof
Thanks for the (quick) review. https://codereview.chromium.org/387873002/diff/60001/LayoutTests/fast/text/font-weight-600.html File LayoutTests/fast/text/font-weight-600.html (right): https://codereview.chromium.org/387873002/diff/60001/LayoutTests/fast/text/font-weight-600.html#newcode1 LayoutTests/fast/text/font-weight-600.html:1: <p style="font-family: Arial, sans-serif; ...
6 years, 5 months ago (2014-07-12 15:30:35 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-12 15:30:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/387873002/160001
6 years, 5 months ago (2014-07-12 15:31:46 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-12 19:32:30 UTC) #8
Message was sent while issue was closed.
Change committed as 177999

Powered by Google App Engine
This is Rietveld 408576698