Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 387863007: Fix the no proprietary codecs build for android (Closed)

Created:
6 years, 5 months ago by lgombos
Modified:
6 years, 5 months ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews, eme-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix the no proprietary codecs build for android. Fix the android build when proprietary_codecs is 0 (USE_PROPRIETARY_CODECS is not defined). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282983

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/cdm/renderer/android_key_systems.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
lgombos
I realize that this might not be a very high profile configuration, but seems legit ...
6 years, 5 months ago (2014-07-12 04:33:18 UTC) #1
lgombos
6 years, 5 months ago (2014-07-12 04:34:20 UTC) #2
lgombos
xhwang@chromium.org: Please review changes in
6 years, 5 months ago (2014-07-12 04:34:37 UTC) #3
xhwang
lgtm Thanks for fixing this!!!
6 years, 5 months ago (2014-07-14 16:07:09 UTC) #4
lgombos
The CQ bit was checked by l.gombos@samsung.com
6 years, 5 months ago (2014-07-14 16:31:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/387863007/20001
6 years, 5 months ago (2014-07-14 16:32:11 UTC) #6
ddorwin
This fix is fine, but note that proprietary_codecs is always defined on Android: https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&q=USE_PROPRIETARY_CODECS&sq=package:chromium&type=cs&l=717
6 years, 5 months ago (2014-07-14 16:51:13 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 18:37:07 UTC) #8
Message was sent while issue was closed.
Change committed as 282983

Powered by Google App Engine
This is Rietveld 408576698