Issue 387863003: aura: Do not synthesize a mouse-move event during a drag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387863003: aura: Do not synthesize a mouse-move event during a drag. (Closed)

Created:
6 years, 5 months ago by sadrul

Modified:
6 years, 5 months ago

Reviewers:
oshima

CC:
chromium-reviews, ben+aura_chromium.org, kalyank

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

aura: Do not synthesize a mouse-move event during a drag. Synthesizing a mouse-move event during a drag can cause an inconsistent sequence of events to be dispatched (e.g. pressed, dragged, dragged, moved, dragged ... released). So do not synthesize mouse-move events when a drag is in progress. The alternate is to synthesize mouse-dragged event instead of a mouse-move event, but in multi-display/multi-host setting, the wrong dispatcher may end up synthesizing the event. So avoid doing that. BUG=389424, 369247, 366096 R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282805

Patch Set 1 #

Patch Set 2 : test #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -0 lines)			Patch
	M	ui/aura/window_event_dispatcher.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	ui/aura/window_event_dispatcher_unittest.cc	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 5 months ago (2014-07-12 06:18:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r282805 (presubmit successful).

Expand Messages | Collapse Messages