Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2314)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.cc

Issue 387773002: Fix badge display for extension action overflow menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/browser_actions_container.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
index d935524540f9a19c9e4c5bbd65a5084b5f4304ed..5c4175ea40217b9bfdca1394a264cb6bdec3d46b 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc
@@ -58,12 +58,6 @@ const int kItemSpacing = ToolbarView::kStandardSpacing;
// Horizontal spacing before the chevron (if visible).
const int kChevronSpacing = kItemSpacing - 2;
-// Padding to make sure the badge appears in the right location vertically when
-// in overflow mode (inside the Chrome menu).
-// TODO(devlin): Remove this hard coding and make sure the badge appears
-// correctly.
-const int kPaddingForBadge = 9;
-
// The maximum number of icons to show per row when in overflow mode (showing
// icons in the application menu).
// TODO(devlin): Compute the right number of icons to show, depending on the
@@ -357,10 +351,7 @@ void BrowserActionsContainer::Layout() {
int x = (index * IconWidth(true)) -
(row_index * IconWidth(true) * kIconsPerMenuRow);
gfx::Rect rect_bounds(
- x,
- IconHeight() * row_index,
- icon_width,
- IconHeight() + kPaddingForBadge);
+ x, IconHeight() * row_index, icon_width, IconHeight());
view->SetBoundsRect(rect_bounds);
view->SetVisible(true);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698