Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 387773002: Fix badge display for extension action overflow menu (Closed)

Created:
6 years, 5 months ago by Devlin
Modified:
6 years, 5 months ago
Reviewers:
Finnur, Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix badge display for extension action overflow menu BUG=393045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282982

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Devlin
(Not urgent - don't review until July 14) ;) It looks like the padding is ...
6 years, 5 months ago (2014-07-10 23:25:35 UTC) #1
Finnur
LGTM
6 years, 5 months ago (2014-07-14 09:37:39 UTC) #2
Finnur
The CQ bit was checked by finnur@chromium.org
6 years, 5 months ago (2014-07-14 09:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/387773002/1
6 years, 5 months ago (2014-07-14 09:38:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 12:52:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 12:54:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/79729)
6 years, 5 months ago (2014-07-14 12:54:24 UTC) #7
Devlin
d'oh - keep forgetting half this code is in c/b/ui/views/toolbar and half is in c/b/ui/views/extensions. ...
6 years, 5 months ago (2014-07-14 15:42:59 UTC) #8
Peter Kasting
LGTM
6 years, 5 months ago (2014-07-14 18:25:21 UTC) #9
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 5 months ago (2014-07-14 18:30:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/387773002/1
6 years, 5 months ago (2014-07-14 18:31:40 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 18:36:24 UTC) #12
Message was sent while issue was closed.
Change committed as 282982

Powered by Google App Engine
This is Rietveld 408576698