Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 387763002: sync: Re-enable some migration integration tests (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

sync: Re-enable some migration integration tests Removes the "ShouldRunMigrationTest()" check from the migration tests. This check was preventing the tests from being run, but did not cause them to emit any errors. Sets these tests to use the legacy python server, since the in-process server does not yet support migration. Removes a DCHECK in StatusChangeChecker, since the MigrationChecker won't work when that condition is enforced. We can look into re-enabling it at some later point. Disables many of the migration tests. They've been broken by changes made to the code since they were disabled. BUG=392989 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282654

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -34 lines) Patch
M chrome/browser/sync/test/integration/migration_test.cc View 8 chunks +20 lines, -27 lines 0 comments Download
M chrome/browser/sync/test/integration/status_change_checker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/status_change_checker.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rlarocque
Here's the first part of re-enabling these tests. Some of them are broken and will ...
6 years, 5 months ago (2014-07-11 00:27:00 UTC) #1
pval...(no longer on Chromium)
lgtm thanks for catching this and re-enabling
6 years, 5 months ago (2014-07-11 00:32:51 UTC) #2
Nicolas Zea
lgtm
6 years, 5 months ago (2014-07-11 17:48:59 UTC) #3
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-11 17:54:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/387763002/1
6 years, 5 months ago (2014-07-11 17:55:57 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 18:42:49 UTC) #6
Message was sent while issue was closed.
Change committed as 282654

Powered by Google App Engine
This is Rietveld 408576698