Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 387753003: Add stub networking_private OpenSSL implementation. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
scheib, mef, Ryan Sleevi
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add stub networking_private OpenSSL implementation. Part of getting OpenSSL working on OS X, the networking_private_crypto.cc implementation is renamed to networking_private_crypto_nss.cc and a stubbed out version networking_private_crypto_openssl.cc. BUG=393023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282526

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -247 lines) Patch
M chrome/chrome_common.gypi View 3 chunks +13 lines, -3 lines 0 comments Download
D chrome/common/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +0 lines, -242 lines 0 comments Download
A + chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc View 1 chunk +4 lines, -2 lines 1 comment Download
A chrome/common/extensions/api/networking_private/networking_private_crypto_openssl.cc View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
davidben
https://codereview.chromium.org/387753003/diff/1/chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc File chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc (right): https://codereview.chromium.org/387753003/diff/1/chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc#newcode73 chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc:73: } (presubmit wanted a git cl format and it ...
6 years, 5 months ago (2014-07-10 23:36:02 UTC) #1
Ryan Sleevi
+mef, who worked on this more in detail :)
6 years, 5 months ago (2014-07-10 23:42:14 UTC) #2
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-10 23:42:54 UTC) #3
scheib
lgtm, nit: change description could be more complete, e.g.: Add stub networking_private OpenSSL implementation. Part ...
6 years, 5 months ago (2014-07-11 01:59:47 UTC) #4
davidben
On 2014/07/11 01:59:47, scheib wrote: > lgtm, nit: change description could be more complete, e.g.: ...
6 years, 5 months ago (2014-07-11 02:33:14 UTC) #5
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-11 02:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/387753003/1
6 years, 5 months ago (2014-07-11 02:37:58 UTC) #7
commit-bot: I haz the power
Change committed as 282526
6 years, 5 months ago (2014-07-11 03:21:20 UTC) #8
mef
On 2014/07/11 03:21:20, I haz the power (commit-bot) wrote: > Change committed as 282526 lgtm, ...
6 years, 5 months ago (2014-07-11 07:35:13 UTC) #9
davidben
6 years, 5 months ago (2014-07-11 13:52:13 UTC) #10
Message was sent while issue was closed.
On 2014/07/11 07:35:13, mef wrote:
> On 2014/07/11 03:21:20, I haz the power (commit-bot) wrote:
> > Change committed as 282526
> 
> lgtm, you probably know it, but I'll mention anyway that the NSS
implementation
> was based on OpenSSL implementation of this API inside of ChromeOS. :)

Oh, handy. That shouldn't be hard to port then.

Powered by Google App Engine
This is Rietveld 408576698