Apply hinting in SkiaTextRenderer::SetFontRenderParams().

ui/gfx/render_text.cc

Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index fb7364b66f2b538f5733867b11afc11330755c6d..9001dc1ac1d318a3d104db55b8ce3f5a55ae8863 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -205,10 +205,24 @@ void SkiaTextRenderer::SetFontRenderParams(const FontRenderParams& params,
   paint_.setLCDRenderText(!background_is_transparent &&
       params.subpixel_rendering != FontRenderParams::SUBPIXEL_RENDERING_NONE);
   paint_.setSubpixelText(params.subpixel_positioning);
-}
+  paint_.setAutohinted(params.autohinter);
 
-void SkiaTextRenderer::SetFontHinting(SkPaint::Hinting hinting) {
-  paint_.setHinting(hinting);
+  SkPaint::Hinting skia_hinting = SkPaint::kNormal_Hinting;
+  switch (params.hinting) {

[msw, 2014/07/11 00:29:10]

optional nit: add a helper to convert the enum (case x: return y).
(it's sad that we have separate gfx, skia, and content enums for this...)

[Daniel Erat, 2014/07/11 03:15:01]

sure, added the helper.

this makes me sad too. do you think that switching FontRenderParams to use the
skia enum for hinting would make sense?

(it'd be nice if the subpixel rendering enum could be unified too, but
FontRenderParams tracks the color component order too, while i think that
SkPaint just uses a bool -- maybe it tracks the order somewhere else.)

[msw, 2014/07/11 04:40:57]

That seems reasonable.
I'm not sure, but it may just assume RGB, I'm not sure how common BGR is.
SkBitmapDevice disables this if kN32_SkColorType != fBitmap.colorType().

+    case FontRenderParams::HINTING_NONE:
+      skia_hinting = SkPaint::kNo_Hinting;
+      break;
+    case FontRenderParams::HINTING_SLIGHT:
+      skia_hinting = SkPaint::kSlight_Hinting;
+      break;
+    case FontRenderParams::HINTING_MEDIUM:
+      skia_hinting = SkPaint::kNormal_Hinting;
+      break;
+    case FontRenderParams::HINTING_FULL:
+      skia_hinting = SkPaint::kFull_Hinting;
+      break;
+  }
+  paint_.setHinting(skia_hinting);
 }
 
 void SkiaTextRenderer::SetTypeface(SkTypeface* typeface) {