Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: sync/sync.gyp

Issue 387733004: Move sync/notifier to components/invalidation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: (GN) Comment out dependency on internal target Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/unacked_invalidation_set_unittest.cc ('k') | sync/sync_internal_api.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/sync.gyp
diff --git a/sync/sync.gyp b/sync/sync.gyp
index 6a14e84f0fbe90b3dc936740dcdc5da478abfe61..3a840e172048e6c880d9afcaefbaf9087e1eea1f 100644
--- a/sync/sync.gyp
+++ b/sync/sync.gyp
@@ -16,10 +16,10 @@
# Notes:
# 1) In static mode, the public 'sync' target has a target type of 'none',
# and is composed of the static library targets 'sync_api', 'sync_core',
- # 'sync_internal_api', 'sync_notifier', and 'sync_proto'.
+ # 'sync_internal_api', and 'sync_proto'.
# 2) In component mode, we build the public 'sync' target into a single DLL,
# which includes the contents of sync_api.gypi, sync_core.gypi,
- # sync_internal_api.gypi, sync_notifier.gypi, and sync_proto.gypi.
+ # sync_internal_api.gypi, and sync_proto.gypi.
# 3) All external targets that depend on anything in sync/ must simply
# declare a dependency on 'sync.gyp:sync'
['component=="static_library"', {
@@ -32,11 +32,9 @@
'sync_api',
'sync_core',
'sync_internal_api',
- 'sync_notifier',
'sync_proto',
],
'export_dependent_settings': [
- 'sync_notifier',
'sync_proto',
],
},
@@ -64,11 +62,9 @@
'sync_core.gypi',
],
'dependencies': [
- 'sync_notifier',
'sync_proto',
],
'export_dependent_settings': [
- 'sync_notifier',
'sync_proto',
],
},
@@ -83,7 +79,6 @@
],
'dependencies': [
'sync_core',
- 'sync_notifier',
'sync_proto',
],
'export_dependent_settings': [
@@ -92,16 +87,6 @@
],
},
- # The sync notifications library.
- {
- 'target_name': 'sync_notifier',
- 'type': 'static_library',
- 'variables': { 'enable_wexit_time_destructors': 1, },
- 'includes': [
- 'sync_notifier.gypi',
- ],
- },
-
# The sync protocol buffer library.
{
# GN version: //sync/protocol
@@ -125,7 +110,6 @@
'sync_api.gypi',
'sync_core.gypi',
'sync_internal_api.gypi',
- 'sync_notifier.gypi',
'sync_proto.gypi',
],
},
« no previous file with comments | « sync/notifier/unacked_invalidation_set_unittest.cc ('k') | sync/sync_internal_api.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698