Move sync/notifier to components/invalidation

sync/internal_api/public/base/invalidation.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_BASE_INVALIDATION_H_
 #define SYNC_INTERNAL_API_PUBLIC_BASE_INVALIDATION_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 17 matching lines @@
   // Factory functions.
   static Invalidation Init(
       const invalidation::ObjectId& id,
       int64 version,
       const std::string& payload);
   static Invalidation InitUnknownVersion(const invalidation::ObjectId& id);
   static Invalidation InitFromDroppedInvalidation(const Invalidation& dropped);
   static scoped_ptr<Invalidation> InitFromValue(
       const base::DictionaryValue& value);
 
   Invalidation(const Invalidation& other);

[maniscalco, 2014/07/16 17:44:46]

Not changing in this CL, but do we need our own copy ctor?  I looked at the
implementation and I don't see how it's different from what the compiler would
provide.  Just curious.

   ~Invalidation();
+  Invalidation& operator=(const Invalidation& other);

[maniscalco, 2014/07/16 17:44:46]

Similar to my question about the cctor, do we need to provide an assignment
operator?  Is the compiler-provided one not what we want here?

If we do need one, consider adding a comment here mentioning why and another
comment down where the class member variables are defined reminding future
maintainer that when they add data members they must update the cctor and oper=.

 
   // Compares two invalidations.  The comparison ignores ack-tracking state.
   bool Equals(const Invalidation& other) const;
 
   invalidation::ObjectId object_id() const;
   bool is_unknown_version() const;
 
   // Safe to call only if is_unknown_version() returns false.
   int64 version() const;
 
@@ skipping 64 matching lines @@
   std::string payload_;
 
   // A locally generated unique ID used to manage local acknowledgements.
   AckHandle ack_handle_;
   syncer::WeakHandle<AckHandler> ack_handler_;
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_BASE_INVALIDATION_H_