Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 387733002: Specialize mint shift code on ia32 for a constant shift amount. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32_test.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_ia32.cc
===================================================================
--- runtime/vm/disassembler_ia32.cc (revision 38138)
+++ runtime/vm/disassembler_ia32.cc (working copy)
@@ -237,7 +237,9 @@
case 0xB6: return "movzx_b";
case 0xB7: return "movzx_w";
case 0xAF: return "imul";
+ case 0xA4: // Fall through.
case 0xA5: return "shld";
+ case 0xAC: // Fall through.
case 0xAD: return "shrd";
case 0xAB: return "bts";
case 0xBD: return "bsr";
@@ -1409,20 +1411,23 @@
}
} else {
data += 2;
- if (f0byte == 0xAB || f0byte == 0xA5 || f0byte == 0xAD) {
+ if (f0byte == 0xAB || f0byte == 0xA4 || f0byte == 0xA5 ||
+ f0byte == 0xAC || f0byte == 0xAD) {
// shrd, shld, bts
Print(f0mnem);
int mod, regop, rm;
GetModRm(*data, &mod, &regop, &rm);
Print(" ");
data += PrintRightOperand(data);
+ Print(",");
+ PrintCPURegister(regop);
if (f0byte == 0xAB) {
- Print(",");
- PrintCPURegister(regop);
+ // Done.
+ } else if (f0byte == 0xA5 || f0byte == 0xAD) {
+ Print(",cl");
} else {
- Print(",");
- PrintCPURegister(regop);
- Print(",cl");
+ Print(", ");
+ PrintInt(*(data++));
}
} else if ((f0byte == 0x10) || (f0byte == 0x11) ||
IsTwoXmmRegInstruction(f0byte)) {
« no previous file with comments | « runtime/vm/assembler_ia32_test.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698