Issue 387693002: Port r282246 to gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387693002: Port r282246 to gn. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
brettw, awong

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Port r282246 to gn. Temporarily disable -Werror on linux, since the gn build isn't yet warning-free with clang. Since gn doesn't use -Werror for all targets yet anyways (http://crbug.com/393046) that seems acceptable. BUG=360311, 393046 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284372

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	build/config/BUILDCONFIG.gn	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	build/config/compiler/BUILD.gn	View	1 2 4	3 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Nico

6 years, 5 months ago (2014-07-20 19:09:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #5 manually as r284372 (tree was closed).