Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 387673002: Delay load "setupapi.dll" for Bluetooth (on Windows). (Closed)

Created:
6 years, 5 months ago by rpaquay
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Delay load "setupapi.dll" for Bluetooth (on Windows). Pre-CL for https://codereview.chromium.org/379943003/: We need to delay load "setupapi.dll" as device/bluetooth now uses "SetupDiGetDevicePropery" which is available on Vista+ only. BUG=388016 TBR=keybuk@chromium.org, armansito@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282472

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M device/bluetooth/bluetooth.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rpaquay
cpu@: https://codereview.chromium.org/379943003/ was reverted because of failure on WinXP, due to the BluetoothAPI now using ...
6 years, 5 months ago (2014-07-10 19:52:28 UTC) #1
cpu_(ooo_6.6-7.5)
delayload is recommended. lgtm
6 years, 5 months ago (2014-07-10 21:35:28 UTC) #2
rpaquay
The CQ bit was checked by rpaquay@chromium.org
6 years, 5 months ago (2014-07-10 21:40:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rpaquay@chromium.org/387673002/1
6 years, 5 months ago (2014-07-10 21:41:12 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 23:55:01 UTC) #5
Message was sent while issue was closed.
Change committed as 282472

Powered by Google App Engine
This is Rietveld 408576698