Improve GN handling of directory templates.

tools/gn/function_get_target_outputs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/build_settings.h"
 #include "tools/gn/file_template.h"
 #include "tools/gn/functions.h"
 #include "tools/gn/ninja_helper.h"
 #include "tools/gn/parse_tree.h"
 #include "tools/gn/settings.h"
 #include "tools/gn/target.h"
 #include "tools/gn/value.h"
 
 namespace functions {
 
 namespace {
 
 void GetOutputsForTarget(const Settings* settings,
                          const Target* target,
                          std::vector<std::string>* ret) {
   switch (target->output_type()) {
-    case Target::ACTION:
-    case Target::COPY_FILES: {
-      // Actions and copy targets: return the outputs specified.
-      const std::vector<SourceFile>& outs = target->action_values().outputs();
+    case Target::ACTION: {
+      // Actions: return the outputs specified.
+      const std::vector<std::string>& outs = target->action_values().outputs();
       ret->reserve(outs.size());
       for (size_t i = 0; i < outs.size(); i++)
-        ret->push_back(outs[i].value());
+        ret->push_back(outs[i]);
       break;
     }
 
+    case Target::COPY_FILES:
     case Target::ACTION_FOREACH: {
-      // Action_foreach: return the result of the template in the outputs.
-      FileTemplate file_template(settings, target->action_values().outputs());
+      // Copy/action_foreach: return the result of the template in the outputs.
+      FileTemplate file_template(settings, target->action_values().outputs(),
+                                 FileTemplate::OUTPUT_ABSOLUTE, SourceDir());
       const std::vector<SourceFile>& sources = target->sources();
       for (size_t i = 0; i < sources.size(); i++)
         file_template.Apply(sources[i], ret);
       break;
     }
 
     case Target::EXECUTABLE:
     case Target::SHARED_LIBRARY:
     case Target::STATIC_LIBRARY:
       // Return the resulting binary file. Currently, fall through to the
@@ skipping 128 matching lines @@
 
   Value ret(function, Value::LIST);
   ret.list_value().reserve(files.size());
   for (size_t i = 0; i < files.size(); i++)
     ret.list_value().push_back(Value(function, files[i]));
 
   return ret;
 }
 
 }  // namespace functions