Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 387633003: Avoid temporary Vectors for arrow function parameter lists (Closed)

Created:
6 years, 5 months ago by aperez
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Avoid temporary Vectors for arrow function parameter lists Instead of using a Collector to gather the parameters from parameter lists of arrow functions and then calling Collector::ToVector() on it, declare the parameters on the function Scope as the AST subtree with the paramters is traversed. This avoids the memory allocations done by Collector, and removed the chance of leaking the result obtained from Collector::ToVector(). BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M src/parser.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/parser.cc View 4 chunks +22 lines, -11 lines 0 comments Download
M src/preparser.h View 3 chunks +14 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
aperez
Apart from avoiding temporary allocations, this should avoid the ASAN bot failures!
6 years, 5 months ago (2014-07-10 19:32:34 UTC) #1
marja
Sorry, I saw this after I had already reverted the CL. Can you create a ...
6 years, 5 months ago (2014-07-11 07:01:14 UTC) #2
aperez
6 years, 5 months ago (2014-07-11 09:35:20 UTC) #3
On 2014/07/11 at 07:01:14, marja wrote:
> Sorry, I saw this after I had already reverted the CL. Can you create a new
whole one with the fix?

Sure thing.

Powered by Google App Engine
This is Rietveld 408576698