Fix the build when use_glib is set to 0.

Fix the build when use_glib is set to 0.
use_glib=0 can work on some embedded setup that doesn't use glib.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283465

[zhaoze.zhou, 2014-07-14 18:34:47]

Please take a look

[zhaoze.zhou, 2014-07-15 21:33:10]

Please take a look

https://codereview.chromium.org/387623002/diff/20001/base/message_loop/messag...
File base/message_loop/message_loop.h (right):

https://codereview.chromium.org/387623002/diff/20001/base/message_loop/messag...
base/message_loop/message_loop.h:558: (defined(OS_LINUX) && !defined(USE_GLIB))
this function is needed x11_event_source_libevent.cc even if we do not use the
glib

[sadrul, 2014-07-15 21:34:42]

https://codereview.chromium.org/387623002/diff/20001/base/message_loop/messag...
File base/message_loop/message_loop.h (right):

https://codereview.chromium.org/387623002/diff/20001/base/message_loop/messag...
base/message_loop/message_loop.h:558: (defined(OS_LINUX) && !defined(USE_GLIB))
On 2014/07/15 21:33:10, zhaoze.zhou wrote:
> this function is needed x11_event_source_libevent.cc even if we do not use the
> glib

Do you mean:

  USE_OZONE || (USE_X11 && !USE_GLIB)

?

[zhaoze.zhou, 2014-07-15 21:41:26]

On 2014/07/15 21:34:42, sadrul wrote:
>
https://codereview.chromium.org/387623002/diff/20001/base/message_loop/messag...
> File base/message_loop/message_loop.h (right):
> 
>
https://codereview.chromium.org/387623002/diff/20001/base/message_loop/messag...
> base/message_loop/message_loop.h:558: (defined(OS_LINUX) &&
!defined(USE_GLIB))
> On 2014/07/15 21:33:10, zhaoze.zhou wrote:
> > this function is needed x11_event_source_libevent.cc even if we do not use
the
> > glib
> 
> Do you mean:
> 
>   USE_OZONE || (USE_X11 && !USE_GLIB)
> 
> ?

Oh, yeah, this makes more sense.

[sadrul, 2014-07-15 22:51:38]

lgtm, fwiw

You should update the CL description and title to mention what build this change
fixes (e.g. use_glib is set to 0 on several platforms (win, mac etc.) that do
not have a broken build without this change).

[zhaoze.zhou, 2014-07-15 23:25:39]

The CQ bit was checked by zhaoze.zhou@partner.samsung.com

[commit-bot: I haz the power, 2014-07-15 23:26:28]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/387623...

[commit-bot: I haz the power, 2014-07-16 08:34:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-16 08:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 08:38:08]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[zhaoze.zhou, 2014-07-16 18:47:58]

thakis@chromium.org: Please review changes in

[Nico, 2014-07-16 18:49:58]

rslgtm

[zhaoze.zhou, 2014-07-16 19:01:08]

The CQ bit was checked by zhaoze.zhou@partner.samsung.com

[commit-bot: I haz the power, 2014-07-16 19:06:42]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/zhaoze.zhou@partner.samsung.com/387623...

[commit-bot: I haz the power, 2014-07-16 19:12:43]

Change committed as 283465