Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 387573003: Revert 282355 "Add chrome/browser/ui to the GN build." (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282355 "Add chrome/browser/ui to the GN build." > Add chrome/browser/ui to the GN build. > > This moves the intermediate grit files: > ui/ui_resources -> ui/resources > ui/ui_strings -> ui/strings > in the GYP build to put it in line with the GN one (and also what one would expect). > > R=ajwong@chromium.org > > Review URL: https://codereview.chromium.org/381463002 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -633 lines) Patch
M trunk/src/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/android_webview/android_webview.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/apps/shell/app_shell.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
D trunk/src/ash/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/ash/ash.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/ash_strings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/ash/resources/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
D trunk/src/ash/strings/BUILD.gn View 1 chunk +0 lines, -9 lines 0 comments Download
M trunk/src/build/config/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/build/config/features.gni View 2 chunks +0 lines, -12 lines 0 comments Download
M trunk/src/build/config/ui.gni View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/resources/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -422 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 12 chunks +23 lines, -22 lines 0 comments Download
M trunk/src/chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_repack_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_resources.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/tools/build/repack_locales.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/components/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/components/feedback.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/components/feedback/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D trunk/src/components/feedback/proto/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
M trunk/src/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_shell.gypi View 1 chunk +3 lines, -3 lines 0 comments Download
M trunk/src/printing/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/ui/resources/ui_resources.gyp View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ui/strings/ui_strings.gyp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
6 years, 5 months ago (2014-07-10 16:55:58 UTC) #1
brettw
6 years, 5 months ago (2014-07-10 16:56:10 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r282359 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698