Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/gdb-jit.h

Issue 387533003: Remove AddCode and RemoveCode GDB JIT entry hooks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: One miro fix. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stubs.cc ('k') | src/gdb-jit.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gdb-jit.h
diff --git a/src/gdb-jit.h b/src/gdb-jit.h
index 323038a654299206ab607e169400553ced3110a8..14536cf0b38e287937cbad1c7fcef697082bcc0a 100644
--- a/src/gdb-jit.h
+++ b/src/gdb-jit.h
@@ -23,59 +23,25 @@ namespace internal {
class CompilationInfo;
-#define CODE_TAGS_LIST(V) \
- V(LOAD_IC) \
- V(KEYED_LOAD_IC) \
- V(STORE_IC) \
- V(KEYED_STORE_IC) \
- V(STUB) \
- V(BUILTIN) \
- V(SCRIPT) \
- V(EVAL) \
- V(FUNCTION)
-
class GDBJITInterface: public AllStatic {
public:
- enum CodeTag {
-#define V(x) x,
- CODE_TAGS_LIST(V)
-#undef V
- TAG_COUNT
- };
-
- static const char* Tag2String(CodeTag tag) {
- switch (tag) {
-#define V(x) case x: return #x;
- CODE_TAGS_LIST(V)
-#undef V
- default:
- return NULL;
- }
- }
+ enum CodeTag { NON_FUNCTION, FUNCTION };
// Main entry point into GDB JIT realized as a JitCodeEventHandler.
static void EventHandler(const v8::JitCodeEvent* event);
- static void AddCode(const char* name,
- Code* code,
- CodeTag tag,
- Script* script,
- CompilationInfo* info);
-
static void AddCode(Handle<Name> name,
Handle<Script> script,
Handle<Code> code,
CompilationInfo* info);
- static void AddCode(CodeTag tag, Name* name, Code* code);
-
- static void AddCode(CodeTag tag, const char* name, Code* code);
+ static void RemoveCodeRange(Address start, Address end);
- static void AddCode(CodeTag tag, Code* code);
+ private:
+ static void AddCode(const char* name, Code* code, CodeTag tag, Script* script,
+ CompilationInfo* info);
static void RemoveCode(Code* code);
-
- static void RemoveCodeRange(Address start, Address end);
};
#define GDBJIT(action) GDBJITInterface::action
« no previous file with comments | « src/code-stubs.cc ('k') | src/gdb-jit.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698