Issue 387493003: Use [Reflect=value] for HTMLInputElement.defaultValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387493003: Use [Reflect=value] for HTMLInputElement.defaultValue (Closed)

Created:
6 years, 5 months ago by Jens Widell

Modified:
6 years, 5 months ago

Reviewers:
haraken, Daniel Bratell

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use [Reflect=value] for HTMLInputElement.defaultValue The HTML specification describes the defaultValue as reflecting the value content attribute. This was also how it was implemented, but unlike all other HTMLInputElement attributes that reflect content attributes, [Reflect] wasn't used for defaultValue. The C++ getter HTMLInputElement::defaultValue() is kept since it is used by other C++ code, and because it's name is a good documentation of what it returns (even if it really just reads the value content attribute.) This does not affect behavior in any way. BUG=392471 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177838

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -7 lines)			Patch
M	Source/core/html/HTMLInputElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/387493003/1

6 years, 5 months ago (2014-07-10 14:07:20 UTC) #4

Message was sent while issue was closed.

Change committed as 177838

Expand Messages | Collapse Messages