Fixing and enhancing OrderedSimpleTaskRunner to allow 100% deterministic tests.

cc/test/ordered_simple_task_runner.h

Index: cc/test/ordered_simple_task_runner.h
diff --git a/cc/test/ordered_simple_task_runner.h b/cc/test/ordered_simple_task_runner.h
index 8850a760bf88de7fb7f7df663324271809d3e8c2..6fe8ea0a383c7baaace7ede97c35c1ef3d28dbb8 100644
--- a/cc/test/ordered_simple_task_runner.h
+++ b/cc/test/ordered_simple_task_runner.h
@@ -7,6 +7,7 @@
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/logging.h"
 #include "base/test/test_simple_task_runner.h"
 
 namespace cc {
@@ -16,14 +17,24 @@ namespace cc {
 // which don't have a delay even though it is queued early.
 class OrderedSimpleTaskRunner : public base::TestSimpleTaskRunner {
  public:
-  OrderedSimpleTaskRunner();
+  OrderedSimpleTaskRunner() : advance_now_(true), now_() {}
 
   virtual void RunPendingTasks() OVERRIDE;
 
+  void SetAdvanceNow(bool advance_now) { advance_now_ = advance_now; }

[Sami, 2014/07/11 17:22:46]

Looks like these should go into the .cc file.

[brianderson, 2014/07/14 23:42:31]

Can you make the method name more descriptive? It isn't very clear without
looking at the implementation that time gets automatically advanced on task
execution.

[mithro-old, 2014/07/16 14:18:12]

I changed it to SetAutoAdvanceNowToPendingTasks but I'm not sure that is the
right name. Open to suggestions.

[mithro-old, 2014/07/16 14:18:12]

Done.

+  void SetNow(base::TimeTicks time) {
+    DCHECK(time > now_);
+    now_ = time;
+  }
+  base::TimeTicks Now() { return now_; }
+
  protected:
   virtual ~OrderedSimpleTaskRunner();
 
  private:
+  bool advance_now_;
+  base::TimeTicks now_;
+
   DISALLOW_COPY_AND_ASSIGN(OrderedSimpleTaskRunner);
 };