Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 387453002: Re-submit of https://codereview.chromium.org/356613002 (Closed)

Created:
6 years, 5 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 5 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Re-submit of https://codereview.chromium.org/356613002 > Add function queryForNewLocalDevices to send query for new local devices, > implement it for mDNS (WiFi devices forthcoming) > > BUG=383167 > > Review URL: https://codereview.chromium.org/356613002 TBR=noamsml@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282315

Patch Set 1 #

Patch Set 2 : Thu 07/10/2014 2:21:31.50 #

Patch Set 3 : Thu 07/10/2014 2:23:32.16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -1 line) Patch
M chrome/browser/extensions/api/gcd_private/gcd_private_api.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 1 2 3 chunks +24 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc View 1 2 chunks +28 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/gcd_private/api/send_query.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/gcd_private/api/send_query.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 5 months ago (2014-07-10 09:25:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/387453002/40001
6 years, 5 months ago (2014-07-10 09:26:13 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 11:26:29 UTC) #3
Message was sent while issue was closed.
Change committed as 282315

Powered by Google App Engine
This is Rietveld 408576698