Issue 38743004: Remove modules/speech dependencies from Internals.

Issue 38743004: Remove modules/speech dependencies from Internals. (Closed)

Created:
7 years, 2 months ago by kihong

Modified:
7 years, 2 months ago

Reviewers:
dmazzoni, abarth-chromium

CC:
blink-reviews, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove modules/speech dependencies from Internals. There are "#include modules/speech/xxx" in the Internals.cpp for testing SpeechSynthesis. They can be eleminated using partial interface Internals since r159635. BUG=171887, 261467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160545

Patch Set 1 #

Total comments: 1

Patch Set 2 : patch #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -27 lines)			Patch
M	LayoutTests/fast/speechsynthesis/speech-synthesis-boundary-events.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-speak.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-speak-invalid-argument-throws.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-voices.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/speechsynthesis/speech-synthesis-voices-changed.html	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/testing/Internals.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/testing/Internals.cpp	View	1	3 chunks	+0 lines, -15 lines	0 comments	Download
M	Source/core/testing/Internals.idl	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/modules/modules.gypi	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
A	Source/modules/speech/testing/InternalsSpeechSynthesis.h	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
A	Source/modules/speech/testing/InternalsSpeechSynthesis.cpp	View	1	1 chunk	+53 lines, -0 lines	0 comments	Download
A	Source/modules/speech/testing/InternalsSpeechSynthesis.idl	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM w/ name change https://codereview.chromium.org/38743004/diff/1/Source/modules/speech/testing/InternalsDOMWindowSpeechSynthesis.h File Source/modules/speech/testing/InternalsDOMWindowSpeechSynthesis.h (right): https://codereview.chromium.org/38743004/diff/1/Source/modules/speech/testing/InternalsDOMWindowSpeechSynthesis.h#newcode39 Source/modules/speech/testing/InternalsDOMWindowSpeechSynthesis.h:39: class InternalsDOMWindowSpeechSynthesis { How did ...

7 years, 2 months ago (2013-10-24 14:19:34 UTC) #2

kihong

On 2013/10/24 14:19:34, abarth wrote: > LGTM w/ name change > > https://codereview.chromium.org/38743004/diff/1/Source/modules/speech/testing/InternalsDOMWindowSpeechSynthesis.h > File ...

7 years, 2 months ago (2013-10-25 00:59:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/38743004/60001

7 years, 2 months ago (2013-10-25 01:46:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/38743004/60001

7 years, 2 months ago (2013-10-25 05:22:57 UTC) #5

Message was sent while issue was closed.

Change committed as 160545

Expand Messages | Collapse Messages