Fix UI glitches in enterprise enrollment recovery.

Fix UI glitches in enterprise enrollment recovery.

Display the name of the domain for which enrollment is recovered and
restart the browser after enrollment recovery to avoid login screen
breakage.

BUG=389481
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283763

[Thiemo Nagel, 2014-07-14 17:01:18]

Hi Julian,

could you please take a look?  This one isn't as urgent as the previous
enrollment recovery CLs.

Thank you and best regards,
Thiemo

[pastarmovj, 2014-07-15 08:44:10]

LGTM with a nit. Please see if you can merge this one back too. I know it is
getting late for this but I feel it will be a big benefit for the feature.

https://codereview.chromium.org/387403003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/387403003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/wizard_controller.cc:1158: if (!dcp_initializer)
return std::string();
nit: line break.

[Thiemo Nagel, 2014-07-16 09:55:32]

Hi Pavel,

could you please take a look at this small addendum to the enrollment recovery
CL?

Thank you!
Thiemo

https://codereview.chromium.org/387403003/diff/1/chrome/browser/chromeos/logi...
File chrome/browser/chromeos/login/wizard_controller.cc (right):

https://codereview.chromium.org/387403003/diff/1/chrome/browser/chromeos/logi...
chrome/browser/chromeos/login/wizard_controller.cc:1158: if (!dcp_initializer)
return std::string();
On 2014/07/15 08:44:10, pastarmovj wrote:
> nit: line break.

Done.

[dzhioev (left Google), 2014-07-16 14:00:09]

On 2014/07/16 09:55:32, Thiemo Nagel wrote:
> Hi Pavel,
> 
> could you please take a look at this small addendum to the enrollment recovery
> CL?
> 
> Thank you!
> Thiemo
> 
>
https://codereview.chromium.org/387403003/diff/1/chrome/browser/chromeos/logi...
> File chrome/browser/chromeos/login/wizard_controller.cc (right):
> 
>
https://codereview.chromium.org/387403003/diff/1/chrome/browser/chromeos/logi...
> chrome/browser/chromeos/login/wizard_controller.cc:1158: if (!dcp_initializer)
> return std::string();
> On 2014/07/15 08:44:10, pastarmovj wrote:
> > nit: line break.
> 
> Done.

LGTM
But consider moving these enrollment-related static methods out from
WizardController in future.

[Thiemo Nagel, 2014-07-16 14:11:39]

> LGTM

Thank you!

> But consider moving these enrollment-related static methods out from
> WizardController in future.

I'm following the example of the existing code, but I agree that some
refactoring would be beneficial.

[Thiemo Nagel, 2014-07-16 16:40:37]

The CQ bit was checked by tnagel@chromium.org

[Thiemo Nagel, 2014-07-16 16:41:33]

The CQ bit was unchecked by tnagel@chromium.org

[Thiemo Nagel, 2014-07-17 10:16:34]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2014-07-17 10:18:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tnagel@chromium.org/387403003/60001

[commit-bot: I haz the power, 2014-07-17 12:59:51]

Change committed as 283763