Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: components/variations/variations_http_header_provider.cc

Issue 387393002: [Variations] Renaming ChromeVariations to ClientVariations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/variations_http_header_provider.cc
diff --git a/components/variations/variations_http_header_provider.cc b/components/variations/variations_http_header_provider.cc
index bc613dfb389a36677eb487aede6b6ba748c0a7e4..adbb241a89e03dfaa965083caf0395152573447f 100644
--- a/components/variations/variations_http_header_provider.cc
+++ b/components/variations/variations_http_header_provider.cc
@@ -13,7 +13,7 @@
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "components/google/core/browser/google_util.h"
-#include "components/variations/proto/chrome_experiments.pb.h"
+#include "components/variations/proto/client_variations.pb.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
#include "net/http/http_request_headers.h"
#include "url/gurl.h"
@@ -53,7 +53,7 @@ void VariationsHttpHeaderProvider::AppendHeaders(
bool incognito,
bool uma_enabled,
net::HttpRequestHeaders* headers) {
- // Note the criteria for attaching Chrome experiment headers:
+ // Note the criteria for attaching client experiment headers:
// 1. We only transmit to Google owned domains which can evaluate experiments.
// 1a. These include hosts which have a standard postfix such as:
// *.doubleclick.net or *.googlesyndication.com or
@@ -211,7 +211,7 @@ void VariationsHttpHeaderProvider::UpdateVariationIDsHeaderValue() {
it != variation_ids_set_.end(); ++it) {
all_variation_ids_set.insert(*it);
}
- metrics::ChromeVariations proto;
+ variations::ClientVariations proto;
Alexei Svitkine (slow) 2014/07/14 19:43:20 Nit: No need for namespace decl here.
Mathieu 2014/07/14 19:50:16 Done.
for (std::set<VariationID>::const_iterator it = all_variation_ids_set.begin();
it != all_variation_ids_set.end(); ++it) {
proto.add_variation_id(*it);

Powered by Google App Engine
This is Rietveld 408576698