Issue 387383002: Fix flags for test cases involving arrow functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387383002: Fix flags for test cases involving arrow functions (Closed)

Created:
6 years, 5 months ago by aperez

Modified:
6 years, 5 months ago

Reviewers:
wingo, rossberg, Michael Starzinger, marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix flags for test cases involving arrow functions There are a lot of tests in cctest/test-parsing/ErrorsArrowFunctions, so it is quite slow. This patch removes some flags to make it faster. Removing three flags that don't affect the test brings down the run time one order of magnitude, which is fast enough even for debug/ASAN bots. Also, remove the unneeded kArrowFunctions flag from cctest/test-parsing/NoErrorsYieldSloppyAllModes BUG= R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22392

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	test/cctest/test-parsing.cc	View	1 2	2 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marja

6 years, 5 months ago (2014-07-15 08:10:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r22392 (presubmit successful).

Expand Messages | Collapse Messages

Issue 387383002: Fix flags for test cases involving arrow functions (Closed)

Description

Patch Set 1 #

Patch Set 2 : Also, run ErrorsArrowFunctions with kArrowFunctions always set #

Patch Set 3 : Do not set kArrowFunctions both in flags and always_flags #

Messages