chrome/renderer/page_load_histograms.cc - Issue 387353003: Modify data_reduction_proxy_header to support tamper detection logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 387353003: Modify data_reduction_proxy_header to support tamper detection logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@work

Patch Set: after sync Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/intercept_download_resource_throttle.cc ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_metrics.cc » ('j') | components/data_reduction_proxy/common/data_reduction_proxy_headers.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/page_load_histograms.cc

diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc

index 307fe4dbb2bd7e99b7a5205106f3919c5ecbfaf4..039cf480a1d6ddbfbfac5030cb5b40432ec3aba9 100644

--- a/chrome/renderer/page_load_histograms.cc

+++ b/chrome/renderer/page_load_histograms.cc

@@ -177,7 +177,8 @@ bool DataReductionProxyWasUsed(WebFrame* frame) {

std::replace(headers.begin(), headers.end(), '\n', '\0');

scoped_refptr<net::HttpResponseHeaders> response_headers(

new net::HttpResponseHeaders(headers));

- return data_reduction_proxy::HasDataReductionProxyViaHeader(response_headers);

+ return data_reduction_proxy::HasDataReductionProxyViaHeader(response_headers,

bolian 2014/07/28 22:59:18 new line before the first argument and put the two

xingx1 2014/07/29 00:47:40 Done.

+ NULL);

}

// Returns true if the provided URL is a referrer string that came from